sanpwc commented on code in PR #4065:
URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1670995838
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -2231,6 +2232,27 @@ public ScheduledExecutorService streamerFlushExecutor() {
return streamerFlushExecutor.get();
}
+ @Override
+ public CompletableFuture<Long> estimatedSize() {
+ var invokeFutures = new CompletableFuture<?>[partitions];
+
+ for (int partId = 0; partId < partitions; partId++) {
+ var replicaGroupId = new TablePartitionId(tableId, partId);
+
+ invokeFutures[partId] = partitionLocation(replicaGroupId)
Review Comment:
I'd rather implement it in a bit different manner. For each partition I'd
call awaitPrimaryReplica() in order to define the location. Just like we do for
any other request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
