sanpwc commented on code in PR #4065:
URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671018873


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -2231,6 +2232,27 @@ public ScheduledExecutorService streamerFlushExecutor() {
         return streamerFlushExecutor.get();
     }
 
+    @Override
+    public CompletableFuture<Long> estimatedSize() {
+        var invokeFutures = new CompletableFuture<?>[partitions];
+
+        for (int partId = 0; partId < partitions; partId++) {

Review Comment:
   What if some partitions are unavailable? Is it intended to await all of them 
or we should also have best effort solution?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to