ibessonov commented on code in PR #4198:
URL: https://github.com/apache/ignite-3/pull/4198#discussion_r1708792250
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -464,6 +463,13 @@ public class IgniteImpl implements Ignite {
localConfigurationValidator
);
+ // Start local configuration to be able to read all local properties.
+ try {
+ lifecycleManager.startComponentsAsync(new ComponentContext(),
nodeCfgMgr);
Review Comment:
Wow, I'm amazed that local configuration manager has absolutely no
dependencies, that's wild!
Could there be any issues with passing a different context instance? Maybe
it would affect stopping somehow? That's just a question, I'm not aware of what
this context is doing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
