Cyrill commented on code in PR #4198:
URL: https://github.com/apache/ignite-3/pull/4198#discussion_r1708817136
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -464,6 +463,13 @@ public class IgniteImpl implements Ignite {
localConfigurationValidator
);
+ // Start local configuration to be able to read all local properties.
+ try {
+ lifecycleManager.startComponentsAsync(new ComponentContext(),
nodeCfgMgr);
Review Comment:
Currently all that a context provides a thread pool where async start'
futures can be executed.
We know for sure `nodeCfgMgr` does not perform any background startup
activity, so it's perfectly fine to pass the default context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
