xtern commented on code in PR #4137:
URL: https://github.com/apache/ignite-3/pull/4137#discussion_r1711503221
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -666,6 +683,16 @@ private void
handleVacuumTxStatesCommand(VacuumTxStatesCommand cmd, long command
txStateStorage.removeAll(cmd.txIds(), commandIndex, commandTerm);
}
+ private void
handleUpdateMinimalActiveTxTimeCommand(UpdateMinimumActiveTxBeginTimeCommand
cmd, long commandIndex, long commandTerm) {
+ // Skips the write command because the storage has already executed it.
+ if (commandIndex <= storage.lastAppliedIndex()) {
+ return;
+ }
+
+ long minActiveTxStartTime0 = minActiveTxStartTime;
+ minActiveTxStartTime = Math.max(cmd.timestamp(),
minActiveTxStartTime0);
Review Comment:
thanks, replaced this with assertion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]