Vladsz83 commented on code in PR #11467:
URL: https://github.com/apache/ignite/pull/11467#discussion_r1716915328


##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/RootQuery.java:
##########
@@ -142,16 +139,10 @@ public RootQuery(
 
         FrameworkConfig frameworkCfg = qryCtx != null ? 
qryCtx.unwrap(FrameworkConfig.class) : null;
 
-        if (frameworkCfg == null)

Review Comment:
   This change is unclear. We still have static `static final FrameworkConfig 
FRAMEWORK_CONFIG`. In general, the idea to make it non-statis, configurable 
look good. But do we need this in current ticket?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to