rpuch commented on code in PR #4361:
URL: https://github.com/apache/ignite-3/pull/4361#discussion_r1756259530
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java:
##########
@@ -872,6 +884,24 @@ public CompletableFuture<IndexWithTerm> raftNodeIndex() {
}));
}
+ @Override
+ public CompletableFuture<Void> becomeLonelyLeader(boolean
pauseLeaderSecondaryDuties) {
Review Comment:
Right now it can't due to the guarantees of the networking. But it's easy to
break them (as they are subtle and implicit), so I added an explicit
synchronization. This should not be a problem as the method does not block for
a long time and it is getting called really rarely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
