rpuch commented on code in PR #4361:
URL: https://github.com/apache/ignite-3/pull/4361#discussion_r1756259973
##########
modules/system-disaster-recovery/src/main/java/org/apache/ignite/internal/disaster/system/SystemDisasterRecoveryManagerImpl.java:
##########
@@ -334,6 +356,26 @@ private static boolean isMajorityOfCmgAreSuccesses(
return successes >= (futuresFromNewCmg.size() + 1) / 2;
}
+ private static String errorMessageForNotEnoughSuccesses(
+ boolean repairMg,
+ Map<String, CompletableFuture<NetworkMessage>> responseFutures
+ ) {
+ if (repairMg) {
+ return String.format(
+ "Did not get successful response from at least one node,
failing cluster reset [failedNode=%s].",
+ findAnyFailedNodeName(responseFutures)
+ );
+ } else {
+ return "Did not get successful responses from new CMG majority,
failing cluster reset.";
+ }
+ }
+
+ private static String findAnyFailedNodeName(Map<String,
CompletableFuture<NetworkMessage>> responseFutures) {
+ return responseFutures.entrySet().stream()
+ .filter(entry -> entry.getValue().isCompletedExceptionally())
+ .findAny().orElseThrow().getKey();
Review Comment:
Improved the error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
