timoninmaxim commented on code in PR #11495:
URL: https://github.com/apache/ignite/pull/11495#discussion_r1759748288


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java:
##########
@@ -1987,7 +1984,7 @@ public List<File> snapshotCacheDirectories(String 
snpName, @Nullable String snpP
      * @return Snapshot metadata instance.
      */
     public SnapshotMetadata readSnapshotMetadata(File snpDir, String consId) 
throws IgniteCheckedException, IOException {
-        return readSnapshotMetadata(new File(snpDir, 
snapshotMetaFileName(consId)));
+        return snpChecker.readSnapshotMetadata(snpDir, consId);

Review Comment:
   Why both SnapshotManager and SnapshotChecker has methods 
`readSnapshotMetadata`? Let's implement them in manager. Checker have reference 
to the manager though `kctx` object.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to