sanpwc commented on code in PR #4684:
URL: https://github.com/apache/ignite-3/pull/4684#discussion_r1833923480
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriverManager.java:
##########
@@ -278,6 +278,11 @@ private void recoverInternalComponentsBusy() {
private PlacementDriver createPlacementDriver() {
return new PlacementDriver() {
+ @Override
+ public boolean isActualAt(HybridTimestamp timestamp) {
+ return
metastore.clusterTime().currentSafeTime().compareTo(timestamp) >= 0;
Review Comment:
Why there's no 'ts.addPhysicalTime(clockService.maxClockSkewMillis());'
Internally methods like getPrimaryReplica uses `clockService.after` that
compares timestamps within the context of clock skew.
```
default boolean after(HybridTimestamp firstTimestamp, HybridTimestamp
anotherTimestamp) {
return compareWithClockSkew(firstTimestamp, anotherTimestamp) > 0;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
