rpuch commented on code in PR #4684:
URL: https://github.com/apache/ignite-3/pull/4684#discussion_r1834117740
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriverManager.java:
##########
@@ -278,6 +278,11 @@ private void recoverInternalComponentsBusy() {
private PlacementDriver createPlacementDriver() {
return new PlacementDriver() {
+ @Override
+ public boolean isActualAt(HybridTimestamp timestamp) {
+ return
metastore.clusterTime().currentSafeTime().compareTo(timestamp) >= 0;
Review Comment:
Implementations of methods like `getAssignments()` do not add max clock skew
when calculating the wait time. I suppose that a 'not adding' version is more
universal as the caller can add the max clock skew (this is what I did: I add
it externally to this method)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
