rpuch commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1849655831
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java:
##########
@@ -86,8 +74,8 @@ public long nowLong() {
}
@Override
- public long currentLong() {
- long current = currentTime();
Review Comment:
`physicalTime() << LOGICAL_TIME_BITS_SIZE` is used 3 times in this class.
How about restoring the `currentTime()` method, but making it private? Like this
```
private long currentTime() {
return physicalTime() << LOGICAL_TIME_BITS_SIZE;
}
```
This will still allow to use `physicalTime()` (overridden by test clock),
but reduce duplication (and `currentTime()` will not be overridable as it's
private).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
