rpuch commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1849860133
##########
modules/core/src/test/java/org/apache/ignite/internal/util/PendingComparableValuesTrackerTest.java:
##########
@@ -256,7 +257,8 @@ void testClose(PendingComparableValuesTracker trackerParam)
{
CompletableFuture<Void> future0 = tracker.waitFor(2);
- tracker.close();
+ // Close is called from dedicated stop worker.
+ IgniteTestUtils.runAsync(tracker::close).join();
Review Comment:
I see: the change is caused because a switch from a busy lock to a
read-write lock happened, and a busy lock contract is a bit different: when
it's blocked, it doesn't allow to enter even to the thread which blocked it. I
think we should introduce another busy lock implementation over striped lock
which will obey to the contract. We could do it in a separate issue, of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
