xtern commented on code in PR #4799:
URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1876045412
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/message/SqlQueryMessageGroup.java:
##########
@@ -40,4 +40,10 @@ public final class SqlQueryMessageGroup {
public static final short QUERY_BATCH_REQUEST = 4;
public static final short QUERY_CLOSE_MESSAGE = 5;
+
+ /** See {@link CancelOperationRequest} for the details. */
+ public static final short OPERATION_CANCEL_REQUEST = 100;
Review Comment:
I thought that since they are not related to the execution of SQL queries
(and are not executed through the `MessageService` introduced in the sql-engine
module) it is better to put them into a separate group.
But overall it probably doesn't matter, so I added the continuous numbering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
