rpuch commented on code in PR #4950:
URL: https://github.com/apache/ignite-3/pull/4950#discussion_r1895378509
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/CmgRaftGroupListener.java:
##########
@@ -350,11 +329,7 @@ private void
changeMetastorageNodes(ChangeMetaStorageInfoCommand command) {
@Override
public void onSnapshotSave(Path path, Consumer<Throwable> doneClo) {
- inBusyLock(busyLock, () -> onSnapshotSaveBusy(path, doneClo));
- }
-
- private CompletableFuture<Void> onSnapshotSaveBusy(Path path,
Consumer<Throwable> doneClo) {
- return storageManager.snapshot(path)
+ storageManager.snapshot(path)
Review Comment:
Because appliedIndex doesn't become invalid anymore. It could happen in the
previous version of this code (when we would skip command execution, but we
would not throw an exception, so FSMCaller would think that the command was
applied). In this PR, we stop applying commands as soon as we see that a
shutdown was requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
