rpuch commented on code in PR #4950:
URL: https://github.com/apache/ignite-3/pull/4950#discussion_r1895408813
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/FSMCallerImpl.java:
##########
@@ -542,6 +546,8 @@ private void doCommitted(final long committedIndex) {
if (iterImpl.hasError()) {
setError(iterImpl.getError());
iterImpl.runTheRestClosureWithError();
+ } else if (shuttingDown) {
+ iterImpl.runTheRestClosureWithShutdownException();
}
final long lastIndex = iterImpl.getIndex() - 1;
Review Comment:
`lastAppliedId` will correspond to last command that was actually applied,
so it seems that it will be correct.
Also, does disaster recovery procedure look at applied index? I though it
looked at last index in log (regardless of whether it was committed or
applied).See `RaftServer#raftNodeIndex()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]