korlov42 commented on code in PR #4929:
URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1896640745
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -362,7 +362,7 @@ public class TableManager implements IgniteTablesInternal,
IgniteComponent {
private final LowWatermark lowWatermark;
- private final HybridTimestampTracker observableTimestampTracker;
+ private final HybridTimestampTrackerImpl observableTimestampTracker;
Review Comment:
let's use interface here and below. Please check this kind of changes
everywhere in your patch
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/IgniteTransactionsImpl.java:
##########
@@ -35,14 +35,14 @@
public class IgniteTransactionsImpl implements IgniteTransactions {
private final TxManager txManager;
- private final HybridTimestampTracker observableTimestampTracker;
+ private final HybridTimestampTrackerImpl observableTimestampTracker;
Review Comment:
let's use interface instead of implementation. Besides, there are number of
methods which are not used anymore. Let's clean up `IgniteTransactionsImpl`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
