vldpyatkov commented on code in PR #4929:
URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1898005463
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java:
##########
@@ -420,27 +421,51 @@ public static TableNotFoundException
tableIdNotFoundException(Integer tableId) {
* @param in Unpacker.
* @param out Packer.
* @param resources Resource registry.
- * @param igniteTransactions Ignite transactions.
+ * @param txManager Ignite transactions.
* @param readOnly Read only flag.
* @return Transaction.
*/
public static @Nullable InternalTransaction readOrStartImplicitTx(
ClientMessageUnpacker in,
ClientMessagePacker out,
ClientResourceRegistry resources,
- IgniteTransactionsImpl igniteTransactions,
+ TxManager txManager,
boolean readOnly
) {
- var tx = readTx(in, out, resources);
+ InternalTransaction tx = readTx(in, out, resources);
if (tx == null) {
- tx = igniteTransactions.beginImplicit(readOnly);
+ tx = startTx(out, txManager, null, true, readOnly);
Review Comment:
Observation timestamp is not necessary for the implicit transaction.
I will add a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
