sashapolo commented on code in PR #4997:
URL: https://github.com/apache/ignite-3/pull/4997#discussion_r1910342081
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/configuration/NodeAttributeConfigurationSchema.java:
##########
@@ -35,6 +35,6 @@ public class NodeAttributeConfigurationSchema {
public String name;
/** Node attribute field. */
- @Value(hasDefault = true)
+ @InjectedValue(hasDefault = true)
Review Comment:
> Maybe renaming it to value would still be a good idea, why not
Why?
> Why have you decide to use this annotation as a replacement for @Value
rather than an addition to it? Like
Because this annotation cannot exist without `@Value`, so what's the point
of always specifying both (or am I missing something)? I would have used
inheritance, if it had been possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
