kgusakov commented on code in PR #5020:
URL: https://github.com/apache/ignite-3/pull/5020#discussion_r1912889007


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -278,6 +278,8 @@ public DistributionZoneManager(
     @Override
     public CompletableFuture<Void> startAsync(ComponentContext 
componentContext) {
         return inBusyLockAsync(busyLock, () -> {
+            partitionDistributionResetTimeoutConfiguration.init();

Review Comment:
   > Also, is there a test that checks that the fix fixes the problem?
   
   This fix is about the wrong `assert`, but when I fixed it I found out the 
issue with 
ItHighAvailablePartitionsRecoveryTest#testHaRecoveryOnZoneTimersRestoreAfterNodeRestart,
 because assertion starts to work. So, this test fixed here also.
   
   > There is not enough test, maybe something else is broken after catalog 
compaction and restarting the node.
   > Or will it be fixed in another ticket?
   
   The root cause of compaction issues is the 
https://issues.apache.org/jira/browse/IGNITE-24057, I thought that we already 
on the same page with it. So, general fix and tests should be added there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to