sanpwc commented on code in PR #5020:
URL: https://github.com/apache/ignite-3/pull/5020#discussion_r1913118465


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -301,8 +303,6 @@ public CompletableFuture<Void> startAsync(ComponentContext 
componentContext) {
             // fires CatalogManager's ZONE_CREATE event, and the state of 
DistributionZoneManager becomes consistent.
             int catalogVersion = catalogManager.latestCatalogVersion();
 
-            partitionDistributionResetTimeoutConfiguration.init();

Review Comment:
   I'd rather expect configuration engine to "call init" on all system 
properties rather than doing that by property owner. What if there are multiple 
owners? Currently it's easier to forget to call init, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to