AMashenkov commented on code in PR #5021:
URL: https://github.com/apache/ignite-3/pull/5021#discussion_r1913005164
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/IgniteSqlImpl.java:
##########
@@ -370,8 +371,13 @@ private CompletableFuture<AsyncResultSet<SqlRow>>
executeAsyncInternal(
CompletableFuture<AsyncResultSet<SqlRow>> result;
try {
+ // TODO: https://issues.apache.org/jira/browse/IGNITE-24021
+ // Converts schema name to its canonical form.
+ String schemaNameInCanonicalForm =
QualifiedName.fromSimple(statement.defaultSchema()).objectName();
Review Comment:
```suggestion
// Use correct implementation to parse identifier.
String schemaName =
QualifiedName.fromSimple(statement.defaultSchema()).objectName();
```
Schema has no canonical form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
