lowka commented on code in PR #5021: URL: https://github.com/apache/ignite-3/pull/5021#discussion_r1914533106
########## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSchemaTest.java: ########## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine; + +import static org.apache.ignite.internal.sql.engine.util.SqlTestUtils.assertThrowsSqlException; + +import org.apache.ignite.internal.sql.BaseSqlIntegrationTest; +import org.apache.ignite.lang.ErrorGroups.Sql; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Test; + +/** + * SQL tests for schema DDL commands. + */ +public class ItSchemaTest extends BaseSqlIntegrationTest { + + @AfterEach + public void dropSchemas() { + dropAllSchemas(); + } + + @Test + public void createSchema() { + sql("CREATE SCHEMA IF NOT EXISTS schema1"); + + sql("CREATE TABLE schema1.test1 (id INT PRIMARY KEY, val INT)"); + sql("INSERT INTO schema1.test1 VALUES (1, 1), (2, 2)"); + + assertQuery("SELECT * FROM schema1.test1") + .returnRowCount(2) + .check(); + + assertThrowsSqlException( + Sql.STMT_VALIDATION_ERR, + "Schema with name 'SCHEMA1' already exists.", + () -> sql("CREATE SCHEMA schema1") + ); + + // Table is still accessible + assertQuery("SELECT * FROM schema1.test1") + .returnRowCount(2) + .check(); + } + + @Test + public void createSchemaIfExists() { + sql("CREATE SCHEMA IF NOT EXISTS schema1"); + + sql("CREATE TABLE schema1.test1 (id INT PRIMARY KEY, val INT)"); + sql("INSERT INTO schema1.test1 VALUES (1, 1), (2, 2)"); + + assertQuery("SELECT * FROM schema1.test1") + .returnRowCount(2) + .check(); + + // Review Comment: Thanks. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
