sanpwc commented on code in PR #5187:
URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1946766230
##########
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -1528,7 +1528,10 @@ private class Node {
placementDriver,
schemaSyncService,
systemDistributedConfiguration,
- sharedTxStateStorage
+ sharedTxStateStorage,
+ txManager,
+ catalogManager,
+ schemaManager
Review Comment:
As far as I can see schemaManager is used in order to
`waitForSchemaAvailability` in `CatalogValidationSchemasSource`, however we
already have `schemaSyncService` in `PartitionReplicaListener` with
`waitForMetadataCompleteness`. I didn't go deeper in order to understand
whether it's the same or not, however from the naming it seems that it's
somewhat relative. Do we really need schemaManager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
