sanpwc commented on code in PR #5187:
URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1946807874
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java:
##########
@@ -72,6 +82,26 @@ private static class CommittedConfiguration {
}
}
+ private final FinishTxCommandHandler finishTxCommandHandler;
+
+ /** Constructor. */
+ public ZonePartitionRaftListener(
+ TxStatePartitionStorage txStatePartitionStorage,
+ TxManager txManager,
+ SafeTimeValuesTracker safeTimeTracker,
+ PendingComparableValuesTracker<Long, Void> storageIndexTracker,
+ ZonePartitionId partitionId
Review Comment:
Please rename it to zonePartitionId or replicationGroupId. PartitionId is
commonly used (e.g. in storages) as the name for partition index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
