sk0x50 commented on code in PR #5245:
URL: https://github.com/apache/ignite-3/pull/5245#discussion_r1963434517
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java:
##########
@@ -163,23 +168,15 @@ private void
processWriteCommand(CommandClosure<WriteCommand> clo) {
} else if (command instanceof PrimaryReplicaChangeCommand) {
// This is a hack for tests, this command is not issued in
production because no zone-wide placement driver exists yet.
// FIXME: https://issues.apache.org/jira/browse/IGNITE-24374
- tableProcessors.values().forEach(listener ->
listener.processCommand(command, commandIndex, commandTerm, safeTimestamp));
-
- result = new IgniteBiTuple<>(null, true);
+ result = processCrossTableProcessorsCommand(command,
commandIndex, commandTerm, safeTimestamp);
Review Comment:
Yep, it was changed intentionally. The previous version always returned
`true` even though no tables applied the command, so we could increase the
`safeTime`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
