sk0x50 commented on code in PR #5245:
URL: https://github.com/apache/ignite-3/pull/5245#discussion_r1963442719
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/message/ReplicaMessageUtils.java:
##########
@@ -68,7 +68,10 @@ public static ReplicationGroupIdMessage
toReplicationGroupIdMessage(
ReplicaMessagesFactory messagesFactory,
ReplicationGroupId replicationGroupId
) {
- assert replicationGroupId instanceof TablePartitionId ||
replicationGroupId instanceof ZonePartitionId : replicationGroupId;
+ assert replicationGroupId instanceof TablePartitionId ||
replicationGroupId instanceof ZonePartitionId :
+ "Unexpected type of replication group identifier [class=" +
replicationGroupId.getClass().getSimpleName()
+ + ", value=" + replicationGroupId
+ + ", requiredType=TablePartitionId or
ZonePartitionId]";
Review Comment:
Well, that is a good question :)
Our [Logging
Guidestyle](https://cwiki.apache.org/confluence/display/IGNITE/Java+Logging+Guidelines)
provides several examples, and I don't see any full stops at the end of a
sentence. On the other hand, [Code Style
Guideline](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-1.4Punctuation)
clearly states:
```
All natural language sentences must follow generally accepted punctuation
rules. It also means that every sentence must end with dot (.), exclamation
point (!) or question mark (?) depending on sentence semantics. This
requirement applies to:
- Code comments (JavaDoc and regular comments).
- Any descriptive messages (for example metrics or JMX properties
description).
- Exception messages.
- Log messages.
- Console output.
```
It looks like, we need to add a full stop here and below. Will add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
