sanpwc commented on code in PR #5310:
URL: https://github.com/apache/ignite-3/pull/5310#discussion_r1975100134
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -555,15 +561,28 @@ private CompletableFuture<?>
createZonePartitionReplicationNode(
this::calculateZoneAssignments,
rebalanceRetryDelayConfiguration
);
-
Supplier<CompletableFuture<Boolean>> startReplicaSupplier = () -> {
+ var storageIndexTracker = new PendingComparableValuesTracker<Long,
Void>(0L);
Review Comment:
I guess it should in order to close it on stop. I've added a ticket for
proper storageIndexTracker closing
https://issues.apache.org/jira/browse/IGNITE-24654 because I don't like an
approach that we have in TableManager with internalTbl.updatePartitionTrackers
- I mean that I don't wont to port it from tables to zones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
