sanpwc commented on code in PR #5310:
URL: https://github.com/apache/ignite-3/pull/5310#discussion_r1975214806
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -600,7 +620,7 @@ private CompletableFuture<?>
createZonePartitionReplicationNode(
.thenCompose(v ->
executeUnderZoneWriteLock(zonePartitionId.zoneId(), () -> {
replicationGroupIds.add(zonePartitionId);
- return falseCompletedFuture();
+ return trueCompletedFuture();
Review Comment:
Because there are no such tests. On the other hand, after adding honest
PlacementDriver, every single attempt to select primary replica starts failing
with an assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
