sashapolo commented on code in PR #5300:
URL: https://github.com/apache/ignite-3/pull/5300#discussion_r1978935380
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2814,7 +2835,11 @@ private CompletableFuture<Void>
stopPartition(TablePartitionId tablePartitionId,
CompletableFuture<Boolean> stopReplicaFuture;
try {
- stopReplicaFuture = replicaMgr.stopReplica(tablePartitionId);
+ // In case of colocation there shouldn't be any table replica and
thus it shouldn't be stopped. Moreover the excessive replica
Review Comment:
1. I think we can remove this change, because the replica should not exist
and `replicaMgr.stopReplica` will be a no-op. But the current approach is also
fine, you can leave it.
2. However, the comment is not correct, for example: `Moreover the excessive
replica stop leads to raft node shutdown regardless was the table replica
there or even didn't ever exist`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
