JAkutenshi commented on code in PR #5300:
URL: https://github.com/apache/ignite-3/pull/5300#discussion_r1978906688
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/StorageUtils.java:
##########
@@ -137,6 +138,7 @@ public static void
throwExceptionDependingOnStorageStateOnRebalance(StorageState
public static void throwExceptionDependingOnStorageState(StorageState
state, String storageInfo) {
switch (state) {
case CLOSED:
+ assert !IgniteSystemProperties.enabledColocation() :
createStorageClosedErrorMessage(storageInfo);
Review Comment:
>why would we suddenly stop being interested in storages being stopped
incorrectly?
Because after colocation we will cover all scenarios and we'll be sure with
them, but
>I think what you want to do is to remove this line
Yes, done.
>fix TC settings to fail if this exception is detected in the logs
It should be a request to `it-assistance`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
