rpuch commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1982810094
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##########
@@ -416,34 +416,49 @@ private InternalTransaction beginBusy(
if (readOnly) {
HybridTimestamp beginTimestamp = clockService.now();
-
- UUID txId =
transactionIdGenerator.transactionIdFor(beginTimestamp, options.priority());
-
- tx = beginReadOnlyTransaction(timestampTracker, beginTimestamp,
txId, implicit, options);
+ tx = beginReadOnlyTransaction(timestampTracker, beginTimestamp,
implicit, options);
} else {
HybridTimestamp beginTimestamp =
createBeginTimestampWithIncrementRwTxCounter();
-
- UUID txId =
transactionIdGenerator.transactionIdFor(beginTimestamp, options.priority());
-
- // TODO: RW timeouts will be supported in
https://issues.apache.org/jira/browse/IGNITE-24244
- // long timeout = options.timeoutMillis() == 0 ?
txConfig.readWriteTimeout().value() : options.timeoutMillis();
- long timeout = 3_000;
-
- tx = new ReadWriteTransactionImpl(this, timestampTracker, txId,
localNodeId, implicit, timeout);
+ tx = beginReadWriteTransaction(timestampTracker, beginTimestamp,
implicit, options);
}
txStateVolatileStorage.initialize(tx);
return tx;
}
+ private ReadWriteTransactionImpl beginReadWriteTransaction(
+ HybridTimestampTracker timestampTracker,
+ HybridTimestamp beginTimestamp,
+ boolean implicit,
+ InternalTxOptions options) {
+
+ UUID txId = transactionIdGenerator.transactionIdFor(beginTimestamp,
options.priority());
Review Comment:
Another thing is that 0 is still used to represent
`USE_TIMEOUT_DEFAULT_FROM_CONFIG`. When I suggested to add a constant
elsewhere, it should have touched `TxManagerImpl` as well, and all other places
where we do the same thing; so `ClientTransactions` does not look like the
proper place for its introduction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
