sashapolo commented on code in PR #5367:
URL: https://github.com/apache/ignite-3/pull/5367#discussion_r1984960760
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -3024,15 +3015,12 @@ private void startTables(long recoveryRevision,
@Nullable HybridTimestamp lwm) {
LOG.debug("Tables started successfully");
}
});
-
- // Forces you to wait until recovery is complete before the metastore
watches is deployed to avoid races with catalog listeners.
- startVv.update(recoveryRevision, (unused, throwable) ->
allTablesStartedFuture);
Review Comment:
I don't fully understand the comment in code, but if it is about "do we have
a strict ordering between table manager recovery and the deployment of meta
storage watches" then the answer is "yes"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
