alievmirza commented on code in PR #5367:
URL: https://github.com/apache/ignite-3/pull/5367#discussion_r1987087408
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -974,28 +959,27 @@ private CompletableFuture<Boolean>
onPrimaryReplicaExpired(PrimaryReplicaEventPa
return falseCompletedFuture();
}
- private void processAssignmentsOnRecovery(long recoveryRevision) {
- var stableAssignmentsPrefix = new
ByteArray(STABLE_ASSIGNMENTS_PREFIX_BYTES);
- var pendingAssignmentsPrefix = new
ByteArray(PENDING_ASSIGNMENTS_QUEUE_PREFIX_BYTES);
+ private CompletableFuture<Void> processAssignmentsOnRecovery(long
recoveryRevision) {
Review Comment:
Let's do the same for
`org.apache.ignite.internal.partition.replicator.PartitionReplicaLifecycleManager#processAssignmentsOnRecovery`,
or refactor to use common code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]