ascherbakoff commented on code in PR #5221:
URL: https://github.com/apache/ignite-3/pull/5221#discussion_r1988607454
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/core/DefaultRaftClientService.java:
##########
@@ -88,19 +93,78 @@ public Future<Message> requestVote(final PeerId peerId,
final RequestVoteRequest
@Override
public Future<Message> appendEntries(final PeerId peerId, final
AppendEntriesRequest request,
- final int timeoutMs, final RpcResponseClosure<AppendEntriesResponse>
done) {
+ final int timeoutMs, final
RpcResponseClosure<AppendEntriesResponse> done) {
// Assign an executor in round-robin fasion.
final Executor executor =
this.appendEntriesExecutorMap.computeIfAbsent(peerId,
- k -> nodeOptions.getStripedExecutor().next());
+ k -> nodeOptions.getStripedExecutor().next());
if (connect(peerId)) { // Replicator should be started asynchronously
by node joined event.
+ if (isHeartbeatRequest(request)) {
Review Comment:
It was implemented this way in the PoC without any dependency issues.
Ok. let's keep it as is, but at least remove copypaste by moving
isHearbeat(..) to utitlities class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
