ptupitsyn commented on code in PR #5402:
URL: https://github.com/apache/ignite-3/pull/5402#discussion_r1998711690
##########
modules/client/src/main/java/org/apache/ignite/client/ClientOperationType.java:
##########
@@ -193,5 +194,15 @@ public enum ClientOperationType {
/**
* Get all primary replicas mapping to cluster nodes ({@link
PartitionManager#primaryReplicasAsync()}).
*/
- PRIMARY_REPLICAS_GET
+ PRIMARY_REPLICAS_GET,
+
+ /**
+ * Get tables ({@link IgniteTables#tables()}) that returns qualified names.
+ */
+ TABLES_GET_QUALIFIED,
+
+ /**
+ * Get table ({@link IgniteTables#table(QualifiedName)}).
+ */
+ TABLE_GET_QUALIFIED,
Review Comment:
This enum exists for the purpose of retry policy implementation. It is
public, unlike `ClientOp`.
I think we can map internal `TABLES_GET_QUALIFIED` to public `TABLES_GET`,
because those are the same from the user point of view.
##########
modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTables.java:
##########
@@ -58,14 +58,14 @@ public List<Table> tables() {
/** {@inheritDoc} */
@Override
public CompletableFuture<List<Table>> tablesAsync() {
- return ch.serviceAsync(ClientOp.TABLES_GET, r -> {
+ return ch.serviceAsync(ClientOp.TABLES_GET_QUALIFIED, r -> {
Review Comment:
If we are connected to an older server (3.0.0), this will fail. We should
check feature flags and fall back to the old behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
