ibessonov commented on code in PR #5654:
URL: https://github.com/apache/ignite-3/pull/5654#discussion_r2048468001
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java:
##########
@@ -308,12 +302,16 @@ private void invokeOnRevisionCallback(long revision,
HybridTimestamp time) {
*
* <p>This method is not thread-safe and must be performed under an
exclusive lock in concurrent scenarios.
*/
- public void advanceSafeTime(HybridTimestamp time) {
+ public void advanceSafeTime(Runnable callback, HybridTimestamp time) {
Review Comment:
I don't like having too many methods for every possible case, it pollutes
the code, and some of those methods become effectively test-only (we already
have such examples in metastorage module, by the way). Let's leave only one
method, I'll document it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
