ibessonov commented on code in PR #5654:
URL: https://github.com/apache/ignite-3/pull/5654#discussion_r2048509506
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java:
##########
@@ -307,13 +302,20 @@ private void invokeOnRevisionCallback(long revision,
HybridTimestamp time) {
* Advances safe time without notifying watches (as there is no new
revision).
*
* <p>This method is not thread-safe and must be performed under an
exclusive lock in concurrent scenarios.
+ *
+ * @param callback A callback that will be executed in meta-storage watch
thread strictly before advancing safe time.
Review Comment:
Isn't that obvious? It's like saying "pass empty closure if you want there
to be no callback"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
