JAkutenshi commented on code in PR #6036:
URL: https://github.com/apache/ignite-3/pull/6036#discussion_r2151573188
##########
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -402,6 +399,19 @@ void before(TestInfo testInfo) throws Exception {
},
AWAIT_TIMEOUT_MILLIS
));
+
+ // Without default zone preparation we will catch "Critical system
error" because test placement driver will return fake primary
+ // replica for default zone out of corresponding assignments.
+ if (colocationEnabled()) {
+ alterDefaultZone(node0);
Review Comment:
We there alter default zone to replica factor 3 vs default 1. We want this
because we don't want to wait for assignments and guess which one node is
chosen for a partition assignment and then should be configured with test
placement driver as primary, right?
##########
modules/placement-driver-api/src/testFixtures/java/org/apache/ignite/internal/placementdriver/TestPlacementDriver.java:
##########
@@ -127,19 +127,20 @@ public void setPrimaryReplicaSupplier(Supplier<? extends
TestReplicaMetaImpl> pr
TestReplicaMetaImpl replicaMeta = primaryReplicaSupplier.get();
- fireEvent(
- PrimaryReplicaEvent.PRIMARY_REPLICA_ELECTED,
- new PrimaryReplicaEventParameters(
- // The only usage of causality token below is
IndexBuildController that doesn't use in tests, so the actual value
- // doesn't matter there yet.
- 0,
- replicaMeta.getReplicationGroupId(),
- replicaMeta.getLeaseholderId(),
- replicaMeta.getLeaseholder(),
- replicaMeta.getStartTime()
- )
- );
-
+ if (replicaMeta != null) {
Review Comment:
Is there any case now when the supplier returns `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
