sanpwc commented on code in PR #6036:
URL: https://github.com/apache/ignite-3/pull/6036#discussion_r2151907174


##########
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -402,6 +399,19 @@ void before(TestInfo testInfo) throws Exception {
                 },
                 AWAIT_TIMEOUT_MILLIS
         ));
+
+        // Without default zone preparation we will catch "Critical system 
error" because test placement driver will return fake primary
+        // replica for default zone out of corresponding assignments.
+        if (colocationEnabled()) {
+            alterDefaultZone(node0);

Review Comment:
   Nope.
   
   - Test placement driver will return some constant node as primary for all 
replication groups. Let's say it's node A.
   - In case of replica factor < NODES_COUNS (3 here in test) some partitions 
won't be located on that node A, because assignments will be either A or B in 
case of replicas 1, or AB in case of replicas 2.
   
   As a result "The local node is outside of the replication group" will be 
thrown because replica was not started on A (fake primary replica).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to