denis-chudov commented on code in PR #6031:
URL: https://github.com/apache/ignite-3/pull/6031#discussion_r2154368574
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -475,14 +474,6 @@ private void updateLeaseBatchInternal() {
if (lease.isProlongable() && agreement.isAccepted()) {
Lease negotiatedLease = agreement.getLease();
- // Lease information is taken from lease tracker,
where it appears on meta storage watch updates, so it can
- // contain stale leases, if watch processing was
delayed for some reason. It is ok: negotiated lease is
- // guaranteed to be already written to meta storage
before negotiation begins, and in this case its start time
- // would be greater than lease's.
- assert negotiatedLease.getStartTime().longValue() >=
lease.getStartTime().longValue()
Review Comment:
This assertion is not needed and can happen in a case when there are two
placement driver active actors.
I forgot that there is a separate ticket for that
https://issues.apache.org/jira/browse/IGNITE-25476
But assuming that assertion removal is one-liner fix, I think it can be
included into this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
