denis-chudov commented on code in PR #6031:
URL: https://github.com/apache/ignite-3/pull/6031#discussion_r2154376872
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -580,7 +580,7 @@ public TableManager(
schemaVersions = new
SchemaVersionsImpl(executorInclinedSchemaSyncService, catalogService,
clockService);
- tablesVv = new IncrementalVersionedValue<>(registry);
+ tablesVv = new IncrementalVersionedValue<>(registry, 100, null);
Review Comment:
It makes the versioned value history longer. In this PR an error was fixed,
when the replica was stopped (transferred to STOPPING state) incorrectly, when
it was still reserved as primary. It made the time before replica stop longer
in some cases (because now the replica always waits for the end of reservation,
which may take up to several seconds). So the history that is required on
replica stop operation may become outdated (see
`TableManager#stopAndDestroyTablePartition`). Longer history will help to avoid
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
