AMashenkov commented on code in PR #6213:
URL: https://github.com/apache/ignite-3/pull/6213#discussion_r2194716798
##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigNode.java:
##########
@@ -41,29 +42,40 @@ public class ConfigNode {
@JsonProperty
private List<ConfigAnnotation> annotations = new ArrayList<>();
@JsonProperty
- private Map<String, ConfigNode> childNodeMap = new LinkedHashMap<>();
+ private final Map<String, ConfigNode> childNodeMap = new LinkedHashMap<>();
@JsonProperty
private String flagsHexString;
+ @JsonProperty
+ private Set<String> legacyPropertyNames;
// Non-serializable fields.
@JsonIgnore
- private ConfigNode parent;
+ @Nullable private ConfigNode parent;
@JsonIgnore
private EnumSet<Flags> flags;
+ public static final ConfigNode INSTANCE = new ConfigNode();
Review Comment:
The purpose of this field is unclear.
Seems, it is used in single place as a poison object.
Let's move this to the place where it is used, rename to `DELETED` and write
a javadoc....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
