AMashenkov commented on code in PR #6213:
URL: https://github.com/apache/ignite-3/pull/6213#discussion_r2195398431
##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeComparator.java:
##########
@@ -105,6 +116,22 @@ private ConfigNode find(ConfigNode node,
Collection<ConfigNode> candidates) {
}
}
+ if (deletedItems == null) {
+ deletedItems = new
ArrayList<>(compContext.configurationModules().size());
+
+ for (ConfigurationModule module :
compContext.configurationModules()) {
+ KeyIgnorer keyIgnorer =
KeyIgnorer.fromDeletedPrefixes(module.deletedPrefixes());
+
+ deletedItems.add(keyIgnorer);
+ }
+ }
Review Comment:
Let's hide this inside the ComparisonContext and add a method
`boolean ctx.shouldIgnore(node.path) { ... }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
