ac1d0globlya commented on code in PR #12194:
URL: https://github.com/apache/ignite/pull/12194#discussion_r2218928715
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientBinaryMarshaller.java:
##########
@@ -97,23 +97,19 @@ public BinaryContext context() {
/** Create new marshaller implementation. */
private GridBinaryMarshaller createImpl(BinaryConfiguration binCfg) {
- IgniteConfiguration igniteCfg = new IgniteConfiguration();
-
if (binCfg == null) {
binCfg = new BinaryConfiguration();
binCfg.setCompactFooter(false);
}
- igniteCfg.setBinaryConfiguration(binCfg);
-
- BinaryContext ctx = new BinaryContext(metaHnd, igniteCfg,
NullLogger.INSTANCE);
+ BinaryContext ctx = new BinaryContext(metaHnd, null, null, binCfg,
NullLogger.INSTANCE);
BinaryMarshaller marsh = new BinaryMarshaller();
marsh.setContext(marshCtx);
- ctx.configure(marsh, binCfg);
+ ctx.configure(marsh, binCfg, new HashMap<>());
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
