sk0x50 commented on code in PR #6282:
URL: https://github.com/apache/ignite-3/pull/6282#discussion_r2222040731
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/exporters/PushMetricExporter.java:
##########
@@ -88,6 +90,10 @@ public void reconfigure(ExporterView newVal) {
}
}
+ protected void reconfigureInternal(ExporterView view) {
Review Comment:
It seems to me, introducing a new method is redundant. For example,
`LogPushExporter` can override `reconfigure` as follows:
```
@Override
protected void reconfigure(ExporterView view) {
LogPushExporterView v = (LogPushExporterView) view;
oneLinePerMetricSource = v.oneLinePerMetricSource();
enabledMetrics = Arrays.asList(v.enabledMetrics());
super.reconfigure(view);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
