sergey-chugunov-1985 commented on code in PR #12200:
URL: https://github.com/apache/ignite/pull/12200#discussion_r2225700147
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/NearCacheUpdates.java:
##########
@@ -17,54 +17,88 @@
package org.apache.ignite.internal.processors.cache.distributed.dht.atomic;
-import java.nio.ByteBuffer;
import java.util.ArrayList;
import java.util.List;
-import org.apache.ignite.internal.GridDirectCollection;
+import org.apache.ignite.internal.Order;
import org.apache.ignite.internal.processors.cache.CacheObject;
import org.apache.ignite.internal.processors.cache.version.GridCacheVersion;
import org.apache.ignite.internal.util.GridLongList;
import org.apache.ignite.internal.util.tostring.GridToStringInclude;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.plugin.extensions.communication.Message;
-import
org.apache.ignite.plugin.extensions.communication.MessageCollectionItemType;
-import org.apache.ignite.plugin.extensions.communication.MessageReader;
-import org.apache.ignite.plugin.extensions.communication.MessageWriter;
import org.jetbrains.annotations.Nullable;
/**
*
*/
public class NearCacheUpdates implements Message {
/** Indexes of keys for which values were generated on primary node (used
if originating node has near cache). */
- @GridDirectCollection(int.class)
+ @Order(value = 0, method = "nearValuesIndexes")
private List<Integer> nearValsIdxs;
/** Indexes of keys for which update was skipped (used if originating node
has near cache). */
- @GridDirectCollection(int.class)
+ @Order(value = 1, method = "skippedIndexes")
private List<Integer> nearSkipIdxs;
/** Values generated on primary node which should be put to originating
node's near cache. */
@GridToStringInclude
- @GridDirectCollection(CacheObject.class)
+ @Order(value = 2, method = "nearValues")
private List<CacheObject> nearVals;
/** Version generated on primary node to be used for originating node's
near cache update. */
+ @Order(value = 3, method = "nearVersion")
private GridCacheVersion nearVer;
/** Near TTLs. */
+ @Order(4)
private GridLongList nearTtls;
/** Near expire times. */
+ @Order(5)
private GridLongList nearExpireTimes;
/**
* @return Values.
*/
- List<CacheObject> nearValues() {
+ public List<CacheObject> nearValues() {
return nearVals;
}
+ /**
+ * @param nearVals values.
+ */
+ public void nearValues(List<CacheObject> nearVals) {
+ this.nearVals = nearVals;
+ }
+
+ /**
+ * @return Near TTLs.
+ */
+ public GridLongList nearTtls() {
+ return nearTtls;
+ }
+
+ /**
+ * @param nearTtls Near TTLs.
+ */
+ public void nearTtls(GridLongList nearTtls) {
+ this.nearTtls = nearTtls;
+ }
+
+ /**
+ * @return Near expire times.
+ */
+ public GridLongList nearExpireTimes() {
Review Comment:
I suggest to add a test for a field of GridLongList type as well. I guess it
should be serialized as an instance of a `Message` interface but I'd like to
make sure that this works as intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
