maksaska commented on code in PR #12200: URL: https://github.com/apache/ignite/pull/12200#discussion_r2233894576
########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/NearCacheUpdates.java: ########## @@ -17,54 +17,88 @@ package org.apache.ignite.internal.processors.cache.distributed.dht.atomic; -import java.nio.ByteBuffer; import java.util.ArrayList; import java.util.List; -import org.apache.ignite.internal.GridDirectCollection; +import org.apache.ignite.internal.Order; import org.apache.ignite.internal.processors.cache.CacheObject; import org.apache.ignite.internal.processors.cache.version.GridCacheVersion; import org.apache.ignite.internal.util.GridLongList; import org.apache.ignite.internal.util.tostring.GridToStringInclude; import org.apache.ignite.internal.util.typedef.internal.S; import org.apache.ignite.plugin.extensions.communication.Message; -import org.apache.ignite.plugin.extensions.communication.MessageCollectionItemType; -import org.apache.ignite.plugin.extensions.communication.MessageReader; -import org.apache.ignite.plugin.extensions.communication.MessageWriter; import org.jetbrains.annotations.Nullable; /** * */ public class NearCacheUpdates implements Message { /** Indexes of keys for which values were generated on primary node (used if originating node has near cache). */ - @GridDirectCollection(int.class) + @Order(value = 0, method = "nearValuesIndexes") Review Comment: I believe at this moment it doesn't matter, since we have a completely new messager generator for ser/der. I kept the order in which the fields were declared to minimize changes in the code. For some messages this order is defferent from historic writeTo/readFrom methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org