Erixonich commented on code in PR #6352:
URL: https://github.com/apache/ignite-3/pull/6352#discussion_r2245908340
##########
modules/platforms/cpp/ignite/client/transaction/transactions.h:
##########
@@ -45,16 +46,18 @@ class transactions {
*
* @return A new transaction.
*/
- IGNITE_API transaction begin() {
- return sync<transaction>([this](auto callback) {
begin_async(std::move(callback)); });
+ IGNITE_API transaction begin(transaction_options tx_opts = {.timeoutMillis
= 0, .readOnly = false}) {
Review Comment:
will introduce separate method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]