Erixonich commented on code in PR #6352:
URL: https://github.com/apache/ignite-3/pull/6352#discussion_r2245922902
##########
modules/platforms/cpp/ignite/client/detail/transaction/transactions_impl.h:
##########
@@ -53,11 +54,12 @@ class transactions_impl {
* Starts a new transaction asynchronously.
*
* @param callback Callback to be called with a new transaction or error
upon completion of asynchronous operation.
+ * @param tx_opts Transaction options.
*/
- IGNITE_API void begin_async(ignite_callback<transaction> callback) {
- auto writer_func = [this](protocol::writer &writer, auto) {
- writer.write_bool(false); // readOnly.
- writer.write(std::int64_t(0)); // timeoutMillis.
+ IGNITE_API void begin_async(ignite_callback<transaction> callback,
transaction_options tx_opts) {
+ auto writer_func = [this, &tx_opts](protocol::writer &writer, auto) {
+ writer.write_bool(tx_opts.readOnly); // readOnly.
+ writer.write(tx_opts.timeoutMillis); // timeoutMillis.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
